The real issue is...
Just to warn you up front, I tend to get very preachy and long winded on this topic, so if you don't like it, stop reading now, lol.
I have seen both sides of the "why are sales declining" debate first hand, both as a customer and now as a worker with bands. And while the view may be slightly different from the two sides, the general idea is the same: the music today lacks quality. And there is a complex reason for this besides bands just stink today (I am going to deal specifically in the rock realm here, because I do not consider rap or hip-hop music.)
Band X builds up a steady following playing in the small venues across the country. They have a solid fan base and well established crowds at every show. There sound is radio friendly and the guys (or gals) are marketable to the MTV generation. They finally get discovered by a label and a deal is worked out. Typically, the deal is what is called a back ended deal, meaning a mid sized advance up front in expectations of profits on the back end. The band is rushed into the studio and a debut major label disc is recorded. Normally, 3-4 of the songs have already been laid down on a self produced EP, and the band already have another 6-7 songs ready to record.
Band X hits the road on a mid-sized venue tour, normally with another label mate who has their second label disc coming out. At this point, Band X has still not made a dime for the label, because tour production costs are still being eaten away from the back end. after 5-6 weeks on the road, the disc is released nationwide, with a strong push of the "it" single to radio markets. Of course, MTV, VH1, Fuse and all the other channels gobble it up and Band X hits the road again, this time for about a 2-3 week marketing blitz. The money slowly starts coming into the label, and some of the advance begins to get paid back. The problem is, in order to stay on top, you have to send them out on the road again. So off Band X goes. Tours of course help drive disc sales, so the sales remain constant. Another single or 2 is released, and after another 12-14 weeks, the disc sales level off and fall, so Band X is no longer the hottest thing out there. The tour finishes, but not all the advance it paid off, and the label wants new material to market. The problem: the band has spent so much time on the road and in promotions that they have not had any time to write anything.
In the old days, this would be fine. A band would take a year to a year and a half to write new material and music, then another 6-8 months recording and producing. Today, you cant do that. You go away for 2 years, and you never come back. So the label rushes Band X back into the studio to record what everyone knows will not be their best work. They get one single done fast and out to radio, and althought it initially shows strong promise, people realize it is no where near the quality of the debut work. When the disc comes out (normally 4 weeks after production started), it contains one, maybe two songs up to the quality of the debut disc, and the rest is just filler.
Fans catch on, and word of mouth begins to spread. But the labels dont catch on, and when it comes time to plan the tour, instead of opting for the less expensive production of the smaller 2000-3000 person venues, they push Band X into a larger 15000 person venue, with higher production and booking costs. Of course, the tour starts to hemeroge money, and the labels decide the best way to fix it is: another disc. So now, you have 3 discs out in the matter or 3 to 3 1/2 years from a group that had maybe one solid disc worth of material. By the time the labels catch on to this, they have already discovered Band Y and begin the process over with them.
Where does all this leave the consumer? Gunshy. We have finally caught on that the single you hear first, the "you ought to know" video, is going to be the best thing we will most likely here from the band. So instead of rushing out and plopping down 20 bucks for the disc, we can just head to itunes, spend the 99 cents and pick up the only thing we really wanted to begin with.